2026-04-03 19:17:53 +08:00
/ * *
* Share link integration tests .
* Covers SHARE - 001 to SHARE - 009 .
* /
import { describe , it , expect , vi , beforeAll , beforeEach , afterAll } from 'vitest' ;
import request from 'supertest' ;
import type { Application } from 'express' ;
const { testDb , dbMock } = vi . hoisted ( ( ) = > {
const Database = require ( 'better-sqlite3' ) ;
const db = new Database ( ':memory:' ) ;
db . exec ( 'PRAGMA journal_mode = WAL' ) ;
db . exec ( 'PRAGMA foreign_keys = ON' ) ;
db . exec ( 'PRAGMA busy_timeout = 5000' ) ;
const mock = {
db ,
closeDb : ( ) = > { } ,
reinitialize : ( ) = > { } ,
getPlaceWithTags : ( placeId : number ) = > {
const place : any = db . prepare ( ` SELECT p.*, c.name as category_name, c.color as category_color, c.icon as category_icon FROM places p LEFT JOIN categories c ON p.category_id = c.id WHERE p.id = ? ` ) . get ( placeId ) ;
if ( ! place ) return null ;
const tags = db . prepare ( ` SELECT t.* FROM tags t JOIN place_tags pt ON t.id = pt.tag_id WHERE pt.place_id = ? ` ) . all ( placeId ) ;
return { . . . place , category : place.category_id ? { id : place.category_id , name : place.category_name , color : place.category_color , icon : place.category_icon } : null , tags } ;
} ,
canAccessTrip : ( tripId : any , userId : number ) = >
db . prepare ( ` SELECT t.id, t.user_id FROM trips t LEFT JOIN trip_members m ON m.trip_id = t.id AND m.user_id = ? WHERE t.id = ? AND (t.user_id = ? OR m.user_id IS NOT NULL) ` ) . get ( userId , tripId , userId ) ,
isOwner : ( tripId : any , userId : number ) = >
! ! db . prepare ( 'SELECT id FROM trips WHERE id = ? AND user_id = ?' ) . get ( tripId , userId ) ,
} ;
return { testDb : db , dbMock : mock } ;
} ) ;
vi . mock ( '../../src/db/database' , ( ) = > dbMock ) ;
vi . mock ( '../../src/config' , ( ) = > ( {
JWT_SECRET : 'test-jwt-secret-for-trek-testing-only' ,
ENCRYPTION_KEY : 'a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2' ,
updateJwtSecret : ( ) = > { } ,
} ) ) ;
import { createApp } from '../../src/app' ;
import { createTables } from '../../src/db/schema' ;
import { runMigrations } from '../../src/db/migrations' ;
import { resetTestDb } from '../helpers/test-db' ;
test: expand test suite to 87.3% backend coverage
Add new integration test files covering previously untested routes:
- categories.test.ts — GET /api/categories
- oidc.test.ts — full OIDC login flow (callback, state, errors)
- settings.test.ts — GET/PUT /api/settings, bulk save
- tags.test.ts — CRUD for trip tags
- todo.test.ts — todo items CRUD and reorder
Add new unit test files covering service-layer logic:
- adminService.test.ts — user/invite management, packing templates, OIDC settings
- atlasService.test.ts — atlas search and place enrichment
- authServiceDb.test.ts — DB-backed auth helpers (login, register, MFA)
- backupService.test.ts — export/import/restore logic
- categoryService.test.ts — category CRUD
- dayService.test.ts — day management and accommodation helpers
- mapsService.test.ts — route/directions helpers
- oidcService.test.ts — OIDC state, auth code, role resolution, user upsert
- packingService.test.ts — packing item/bag/template operations
- placeService.test.ts — place CRUD and tag attachment
- settingsService.test.ts — settings get/set/bulk
- tagService.test.ts — tag CRUD
- todoService.test.ts — todo CRUD and reorder
- tripService.test.ts — trip CRUD, member management, archiving
- vacayService.test.ts — vacay integration helpers
- tripAccess.test.ts (middleware) — requireTripAccess middleware
Expand existing integration and unit test files with additional cases
across admin, atlas, auth, backup, collab, days, files, maps, memories
(Immich/Synology), notifications, places, reservations, share, vacay,
weather, auth middleware, ephemeral tokens, notification preferences,
permissions, SSRF guard, and WebSocket connection tests.
Update test helpers (factories.ts, test-db.ts) with new factory
functions and seed data required by the expanded suite.
Fix minor issues in server/src/routes/reservations.ts and
server/src/services/atlasService.ts surfaced by new test coverage.
Update sonar-project.properties to reflect new coverage thresholds.
2026-04-07 02:06:46 +08:00
import { createUser , createTrip , addTripMember , createDay , createPlace , createDayAssignment , createDayNote } from '../helpers/factories' ;
2026-04-03 19:17:53 +08:00
import { authCookie } from '../helpers/auth' ;
import { loginAttempts , mfaAttempts } from '../../src/routes/auth' ;
const app : Application = createApp ( ) ;
beforeAll ( ( ) = > {
createTables ( testDb ) ;
runMigrations ( testDb ) ;
} ) ;
beforeEach ( ( ) = > {
resetTestDb ( testDb ) ;
loginAttempts . clear ( ) ;
mfaAttempts . clear ( ) ;
} ) ;
afterAll ( ( ) = > {
testDb . close ( ) ;
} ) ;
describe ( 'Share link CRUD' , ( ) = > {
it ( 'SHARE-001 — POST creates share link with default permissions' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id ) ;
const res = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { } ) ;
expect ( res . status ) . toBe ( 201 ) ;
expect ( res . body . token ) . toBeDefined ( ) ;
expect ( typeof res . body . token ) . toBe ( 'string' ) ;
} ) ;
it ( 'SHARE-002 — POST creates share link with custom permissions' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id ) ;
const res = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { share_budget : false , share_packing : true } ) ;
expect ( res . status ) . toBe ( 201 ) ;
expect ( res . body . token ) . toBeDefined ( ) ;
} ) ;
it ( 'SHARE-003 — POST again updates share link permissions' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id ) ;
const first = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { share_budget : true } ) ;
const second = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { share_budget : false } ) ;
// Same token (update, not create)
expect ( second . body . token ) . toBe ( first . body . token ) ;
} ) ;
it ( 'SHARE-004 — GET returns share link status' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id ) ;
await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { } ) ;
const res = await request ( app )
. get ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) ) ;
expect ( res . status ) . toBe ( 200 ) ;
expect ( res . body . token ) . toBeDefined ( ) ;
} ) ;
it ( 'SHARE-004 — GET returns null token when no share link exists' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id ) ;
const res = await request ( app )
. get ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) ) ;
expect ( res . status ) . toBe ( 200 ) ;
expect ( res . body . token ) . toBeNull ( ) ;
} ) ;
it ( 'SHARE-005 — DELETE removes share link' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id ) ;
await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { } ) ;
const del = await request ( app )
. delete ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) ) ;
expect ( del . status ) . toBe ( 200 ) ;
expect ( del . body . success ) . toBe ( true ) ;
const status = await request ( app )
. get ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) ) ;
expect ( status . body . token ) . toBeNull ( ) ;
} ) ;
} ) ;
describe ( 'Shared trip access' , ( ) = > {
it ( 'SHARE-006 — GET /shared/:token returns trip data with all sections' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id , { title : 'Paris Adventure' } ) ;
const create = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { share_budget : true , share_packing : true } ) ;
const token = create . body . token ;
const res = await request ( app ) . get ( ` /api/shared/ ${ token } ` ) ;
expect ( res . status ) . toBe ( 200 ) ;
expect ( res . body . trip ) . toBeDefined ( ) ;
expect ( res . body . trip . title ) . toBe ( 'Paris Adventure' ) ;
} ) ;
it ( 'SHARE-007 — GET /shared/:token hides budget when share_budget=false' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id ) ;
const create = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { share_budget : false } ) ;
const token = create . body . token ;
const res = await request ( app ) . get ( ` /api/shared/ ${ token } ` ) ;
expect ( res . status ) . toBe ( 200 ) ;
// Budget should be an empty array when share_budget is false
expect ( Array . isArray ( res . body . budget ) ) . toBe ( true ) ;
expect ( res . body . budget ) . toHaveLength ( 0 ) ;
} ) ;
it ( 'SHARE-008 — GET /shared/:invalid-token returns 404' , async ( ) = > {
const res = await request ( app ) . get ( '/api/shared/invalid-token-xyz' ) ;
expect ( res . status ) . toBe ( 404 ) ;
} ) ;
it ( 'SHARE-009 — non-member cannot create share link' , async ( ) = > {
const { user : owner } = createUser ( testDb ) ;
const { user : other } = createUser ( testDb ) ;
const trip = createTrip ( testDb , owner . id ) ;
const res = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( other . id ) )
. send ( { } ) ;
expect ( res . status ) . toBe ( 404 ) ;
} ) ;
} ) ;
test: expand test suite to 87.3% backend coverage
Add new integration test files covering previously untested routes:
- categories.test.ts — GET /api/categories
- oidc.test.ts — full OIDC login flow (callback, state, errors)
- settings.test.ts — GET/PUT /api/settings, bulk save
- tags.test.ts — CRUD for trip tags
- todo.test.ts — todo items CRUD and reorder
Add new unit test files covering service-layer logic:
- adminService.test.ts — user/invite management, packing templates, OIDC settings
- atlasService.test.ts — atlas search and place enrichment
- authServiceDb.test.ts — DB-backed auth helpers (login, register, MFA)
- backupService.test.ts — export/import/restore logic
- categoryService.test.ts — category CRUD
- dayService.test.ts — day management and accommodation helpers
- mapsService.test.ts — route/directions helpers
- oidcService.test.ts — OIDC state, auth code, role resolution, user upsert
- packingService.test.ts — packing item/bag/template operations
- placeService.test.ts — place CRUD and tag attachment
- settingsService.test.ts — settings get/set/bulk
- tagService.test.ts — tag CRUD
- todoService.test.ts — todo CRUD and reorder
- tripService.test.ts — trip CRUD, member management, archiving
- vacayService.test.ts — vacay integration helpers
- tripAccess.test.ts (middleware) — requireTripAccess middleware
Expand existing integration and unit test files with additional cases
across admin, atlas, auth, backup, collab, days, files, maps, memories
(Immich/Synology), notifications, places, reservations, share, vacay,
weather, auth middleware, ephemeral tokens, notification preferences,
permissions, SSRF guard, and WebSocket connection tests.
Update test helpers (factories.ts, test-db.ts) with new factory
functions and seed data required by the expanded suite.
Fix minor issues in server/src/routes/reservations.ts and
server/src/services/atlasService.ts surfaced by new test coverage.
Update sonar-project.properties to reflect new coverage thresholds.
2026-04-07 02:06:46 +08:00
describe ( 'Shared trip — day assignments and notes' , ( ) = > {
it ( 'SHARE-010 — shared trip with days and assignments includes place data in assignments' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id , { title : 'Rome Trip' } ) ;
const day = createDay ( testDb , trip . id , { date : '2025-06-01' } ) ;
const place = createPlace ( testDb , trip . id , { name : 'Colosseum' , lat : 41.89 , lng : 12.49 } ) ;
createDayAssignment ( testDb , day . id , place . id , { notes : 'Amazing site' } ) ;
const create = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { } ) ;
const token = create . body . token ;
const res = await request ( app ) . get ( ` /api/shared/ ${ token } ` ) ;
expect ( res . status ) . toBe ( 200 ) ;
expect ( res . body . days ) . toHaveLength ( 1 ) ;
const dayAssignments = res . body . assignments [ day . id ] ;
expect ( Array . isArray ( dayAssignments ) ) . toBe ( true ) ;
expect ( dayAssignments ) . toHaveLength ( 1 ) ;
expect ( dayAssignments [ 0 ] . place . name ) . toBe ( 'Colosseum' ) ;
expect ( dayAssignments [ 0 ] . place . lat ) . toBe ( 41.89 ) ;
} ) ;
it ( 'SHARE-011 — shared trip with day notes includes notes in response' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id , { title : 'Notes Trip' } ) ;
const day = createDay ( testDb , trip . id , { date : '2025-07-01' } ) ;
createDayNote ( testDb , day . id , trip . id , { text : 'Meet at the station' } ) ;
const create = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { } ) ;
const token = create . body . token ;
const res = await request ( app ) . get ( ` /api/shared/ ${ token } ` ) ;
expect ( res . status ) . toBe ( 200 ) ;
const dayNotes = res . body . dayNotes [ day . id ] ;
expect ( Array . isArray ( dayNotes ) ) . toBe ( true ) ;
expect ( dayNotes ) . toHaveLength ( 1 ) ;
expect ( dayNotes [ 0 ] . text ) . toBe ( 'Meet at the station' ) ;
} ) ;
it ( 'SHARE-012 — share_collab=true includes collab messages in response' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id ) ;
testDb . prepare ( 'INSERT INTO collab_messages (trip_id, user_id, text, deleted) VALUES (?, ?, ?, 0)' ) . run ( trip . id , user . id , 'Hello team!' ) ;
const create = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { share_collab : true } ) ;
const token = create . body . token ;
const res = await request ( app ) . get ( ` /api/shared/ ${ token } ` ) ;
expect ( res . status ) . toBe ( 200 ) ;
expect ( Array . isArray ( res . body . collab ) ) . toBe ( true ) ;
expect ( res . body . collab ) . toHaveLength ( 1 ) ;
expect ( res . body . collab [ 0 ] . text ) . toBe ( 'Hello team!' ) ;
} ) ;
it ( 'SHARE-013 — assignments empty when days have no assignments' , async ( ) = > {
const { user } = createUser ( testDb ) ;
const trip = createTrip ( testDb , user . id ) ;
createDay ( testDb , trip . id , { date : '2025-08-01' } ) ;
const create = await request ( app )
. post ( ` /api/trips/ ${ trip . id } /share-link ` )
. set ( 'Cookie' , authCookie ( user . id ) )
. send ( { } ) ;
const token = create . body . token ;
const res = await request ( app ) . get ( ` /api/shared/ ${ token } ` ) ;
expect ( res . status ) . toBe ( 200 ) ;
expect ( res . body . days ) . toHaveLength ( 1 ) ;
expect ( res . body . assignments ) . toEqual ( { } ) ;
} ) ;
} ) ;